Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Database #470

Merged
merged 4 commits into from
Aug 27, 2023
Merged

Refactoring Database #470

merged 4 commits into from
Aug 27, 2023

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Aug 27, 2023

Create interface for database abstraction. Will need further refactoring for DI mechanism.

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #470 (173464f) into main (45e1baf) will decrease coverage by 0.72%.
The diff coverage is 83.78%.

@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
- Coverage   79.11%   78.39%   -0.72%     
==========================================
  Files          30       39       +9     
  Lines        3476     3504      +28     
==========================================
- Hits         2750     2747       -3     
- Misses        580      613      +33     
+ Partials      146      144       -2     
Files Changed Coverage Δ
internal/persistence/jsondb/database.go 70.19% <53.33%> (ø)
internal/runner/job.go 65.71% <66.66%> (ø)
internal/agent/agent.go 75.82% <69.23%> (+0.50%) ⬆️
cmd/common.go 76.47% <76.47%> (ø)
cmd/restart.go 92.98% <92.98%> (ø)
internal/controller/controller.go 74.87% <96.15%> (-0.25%) ⬇️
cmd/dry.go 100.00% <100.00%> (ø)
cmd/retry.go 100.00% <100.00%> (ø)
cmd/root.go 75.00% <100.00%> (+7.35%) ⬆️
cmd/scheduler.go 100.00% <100.00%> (ø)
... and 7 more

@yohamta yohamta merged commit f5e55a1 into main Aug 27, 2023
3 checks passed
@yohamta yohamta deleted the refactoring branch August 27, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant